Conversation
Summary of ChangesHello @keyboardsurfer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes clear code ownership for the AI-related snippets directory by updating the CODEOWNERS file. This ensures that changes to these specific files will require review and approval from the designated Android DevRel AI team, streamlining the review process and maintaining code quality for this section of the codebase. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
yrezgui
left a comment
There was a problem hiding this comment.
Can we move the AI snippets to a dedicated module instead of being part of misc
9008757 to
567dfd2
Compare
5f5d552 to
d7a5941
Compare
kkuan2011
left a comment
There was a problem hiding this comment.
Thanks Ben for moving the ai content into its own module, that'll be easier for managing the snippets going forward! I got confused on some of the content in the pR that's not AI-specific if you could clarify, and left some suggestions on making the package name consistent and making the module as bare-bones as possible (reducing # of dependencies, boilerplate files, etc..).
| import org.junit.Test; | ||
| import static org.junit.Assert.assertFalse; | ||
|
|
||
| public class DeviceCompatibilityModeTestJavaSnippets { |
| } | ||
| // [END android_device_compatibility_mode_assert_isLetterboxed_java] | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: we can remove these comments like these since it's implied and remove the extra blank lines too
| import org.junit.Rule | ||
| import org.junit.Test | ||
|
|
||
| class DeviceCompatibilityModeTestKotlinSnippets { |
There was a problem hiding this comment.
Same comments in this class as in DeviceCompatibilityModeTestJavaSnippets
|
|
||
| package com.example.snippets.navigation | ||
|
|
||
| enum class Destination(val route: String, val title: String) { |
There was a problem hiding this comment.
can we move this into the file that uses Destination?
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.example.snippets; |
There was a problem hiding this comment.
should we specify a more specific pacakge? like com.example.snippets.ai?
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <resources xmlns:window="http://schemas.android.com/apk/res-auto"> |
There was a problem hiding this comment.
can we remove this file?
| <manifest xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <permission android:name="com.example.snippets.CUSTOM_PERMISSION"/> | ||
|
|
||
| <!--[START android_broadcast_receiver_10_manifest_permission]--> |
There was a problem hiding this comment.
do we need these region tags in the manifest file? we generally discourage doing so, and just hardcode any manifest snippets in the markdown file
|
|
||
| android { | ||
| compileSdk = libs.versions.compileSdk.get().toInt() | ||
| namespace = "com.example.snippets" |
There was a problem hiding this comment.
can we pick a more specific name to ai?
| @@ -0,0 +1,21 @@ | |||
| # Add project specific ProGuard rules here. | |||
There was a problem hiding this comment.
is this proguard file deprecated now? can we remove it?
| } | ||
|
|
||
| } | ||
| dependencies { |
There was a problem hiding this comment.
are all these dependencies needed for the ai module? can we omit the ones that are not needed?
No description provided.