Skip to content

[Merge it on 11th March,2026] FlexBox Snippet migration from DSL to function based config#827

Open
srikrishnasakunia wants to merge 1 commit intoadaptive-layoutsfrom
sri_adaptive_layouts
Open

[Merge it on 11th March,2026] FlexBox Snippet migration from DSL to function based config#827
srikrishnasakunia wants to merge 1 commit intoadaptive-layoutsfrom
sri_adaptive_layouts

Conversation

@srikrishnasakunia
Copy link
Contributor

Updated the code snippets for FlexBox to migrate from DSL to function based config for FlexBox.

@srikrishnasakunia srikrishnasakunia requested review from a team, kkuan2011 and yrezgui as code owners March 5, 2026 09:15
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors existing FlexBox code examples to align with a new function-based configuration API, enhancing consistency and potentially improving readability for developers. Additionally, it includes an update to the latest beta version of the Compose framework, ensuring the project benefits from recent improvements and bug fixes.

Highlights

  • FlexBox Snippet Migration: Updated all FlexBox code snippets to use a function-based configuration API instead of the previous DSL property assignment style for various properties like direction, alignItems, wrap, grow, basis, shrink, alignSelf, and order.
  • Compose Version Update: Upgraded the compose-latest dependency from 1.11.0-alpha06 to 1.11.0-beta01.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • compose/snippets/src/main/java/com/example/compose/snippets/layouts/FlexBoxSnippets.kt
    • Migrated FlexBox configuration properties (e.g., direction, alignItems, wrap, alignContent, justifyContent) from direct assignment to function calls.
    • Migrated FlexBox item properties (e.g., grow, basis, shrink, alignSelf, order) within the Modifier.flex block from direct assignment to function calls.
  • gradle/libs.versions.toml
    • Updated the compose-latest version from 1.11.0-alpha06 to 1.11.0-beta01.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the FlexBox code snippets from a property-based DSL to a function-based configuration. The changes are applied consistently across all usage examples in compose/snippets/src/main/java/com/example/compose/snippets/layouts/FlexBoxSnippets.kt. The compose-latest dependency version has also been updated to 1.11.0-beta01 in gradle/libs.versions.toml to support this new API. The changes are straightforward and correctly implement the described API migration. I have not identified any issues of medium, high, or critical severity.

Copy link
Contributor

@kkuan2011 kkuan2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the build is failing, is it related to the compose-latest version bump?

@srikrishnasakunia
Copy link
Contributor Author

I think the build is failing, is it related to the compose-latest version bump?

Hey @kkuan2011, the build is failing because the dependent compose version will release on 11th March,2026.

Copy link
Contributor

@kkuan2011 kkuan2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sounds good to merge after March 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants