Skip to content

Av/347 fix token refresh expiry#664

Merged
gjwgit merged 22 commits into
devfrom
av/347_fix_token_refresh_expiry
Jun 10, 2026
Merged

Av/347 fix token refresh expiry#664
gjwgit merged 22 commits into
devfrom
av/347_fix_token_refresh_expiry

Conversation

@anushkavidanage

Copy link
Copy Markdown
Collaborator

Pull Request Details

Description

_getRefreshedAuthData now refreshes when the token is null or within a 2-minute buffer of expiry (not just strictly expired), and falls back to existing data if refreshToken() returns null.

Related Issues

anusii/solidui#347

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

Use the corresponding solid_auth branch: https://github.com/anusii/solid_auth/tree/av/347_fix_token_refresh_expiry
Run the example app and wait for the access token to get expired. Then run any POD access function such as read or write to see if that works. If it works, that means the access token has been refreshed silently in background.

Checklist

  • Screenshots included here/in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@gjwgit gjwgit merged commit 567dee6 into dev Jun 10, 2026
18 of 20 checks passed
@gjwgit gjwgit deleted the av/347_fix_token_refresh_expiry branch June 10, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants