Skip to content

Amogh/optimize login latency backup#337

Open
Amoghhosamane wants to merge 5 commits into
anusii:devfrom
Amoghhosamane:Amogh/optimize_login_latency_backup
Open

Amogh/optimize login latency backup#337
Amoghhosamane wants to merge 5 commits into
anusii:devfrom
Amoghhosamane:Amogh/optimize_login_latency_backup

Conversation

@Amoghhosamane

Copy link
Copy Markdown
## Pull Request Details

### Description
This PR resolves a CI lint block where the GitHub Actions workflow was failing due to an invalid dependency constraint.
Specifically, pub.dev does not permit publishable packages to depend on `git` repositories. The `solidpod` dependency was listed as a git reference in `pubspec.yaml`, which triggered the `invalid_dependency` error.

**What was changed:**
1. Replaced the git dependency on `solidpod` with the proper pub.dev version `^0.12.10` in both `pubspec.yaml` and `example/pubspec.yaml`.
2. Synced the branch with all the latest upstream updates by merging the `upstream/dev` branch into `Amogh/optimize_login_latency`.
3. Resolved all resulting merge conflicts across `pubspec.yaml`, `example/pubspec.yaml`, `lib/solidui.dart` (sorting exports alphabetically), and `example/lib/home.dart` (reordering and cleanup of duplicate/conflicting imports).
4. Updated `CHANGELOG.md` to document the fix.

### Related Issues
Fixes #1136

### Type of Change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

### How To Test?
To verify the fixes and ensure everything compiles and passes lints, run:
```bash
flutter pub get
flutter analyze --fatal-infos

Checklist

  • Screenshots included here/in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

…check

- Reorder imports to follow Flutter → external packages → project structure
- Add blank lines between each import group
- Disable conflicting directives_ordering lint rule in analysis_options.yaml
  (import_order_lint and directives_ordering are mutually exclusive)
- Apply dart format to all affected files

Affected files:
  lib/src/utils/solid_file_operations_download.dart
  lib/src/utils/solid_file_operations_upload.dart
  lib/src/widgets/solid_about_button.dart
  lib/src/widgets/solid_file_operations.dart
  lib/src/widgets/solid_file_uploader.dart
  lib/src/widgets/solid_file_uploader_helpers.dart
  lib/src/widgets/solid_login_build_helper.dart
  lib/src/widgets/solid_login_buttons.dart
  lib/src/widgets/solid_nav_drawer_header.dart
  lib/src/widgets/solid_nav_drawer_url_helper.dart
  lib/src/widgets/solid_profile_editor.dart
  lib/src/widgets/solid_scaffold_helpers.dart
  lib/src/widgets/solid_status_bar.dart
- Reorganize imports in 13 target files to follow Flutter -> external -> project hierarchy.
- Run import_order on the entire codebase to fix all 158+ violations.
- Disable directives_ordering lint in analysis_options.yaml to support import_order_lint grouping rules.
- Format all files with dart format.
…figuration

- Enforced Flutter -> External -> Project import hierarchy with blank lines.
- Added import_order configuration to pubspec.yaml for both root and example.
- Disabled conflicting directives_ordering lint in analysis_options.yaml.
- Applied dart format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant