Adds support for retrieving the slot in which migration to alpenglow happened#1703
Draft
akhi3030 wants to merge 1 commit into
Draft
Adds support for retrieving the slot in which migration to alpenglow happened#1703akhi3030 wants to merge 1 commit into
akhi3030 wants to merge 1 commit into
Conversation
|
akhi3030
force-pushed
the
akhi3030/add-get-ag-migration-slot
branch
3 times, most recently
from
May 26, 2026 17:11
fc029ed to
c61c3d7
Compare
BundleMonUnchanged files (147)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
akhi3030
force-pushed
the
akhi3030/add-get-ag-migration-slot
branch
2 times, most recently
from
May 26, 2026 17:24
216bebb to
223adb0
Compare
akhi3030
changed the title
akhi3030
force-pushed
the
akhi3030/add-get-ag-migration-slot
branch
from
May 26, 2026 17:50
223adb0 to
fc03761
Compare
akhi3030
force-pushed
the
akhi3030/add-get-ag-migration-slot
branch
from
May 27, 2026 11:05
fc03761 to
0caa783
Compare
akhi3030
marked this pull request as ready for review
May 27, 2026 11:40
mcintyre94
reviewed
May 28, 2026
mcintyre94
left a comment
mcintyre94
left a comment
Member
There was a problem hiding this comment.
Thanks for this! I'll hold on merging until this is closer to release to avoid confusion, but will keep it open.
It'd also be worth us adding a unit test closer to the time, as we have for other RPC methods.
| * | ||
| * @see https://solana.com/docs/rpc/http/getalpenglowmigrationslot | ||
| */ | ||
| getAlpenglowMigrationSlot(config?: Readonly<object>): GetAlpenglowMigrationSlotApiResponse; |
Member
There was a problem hiding this comment.
If the request doesn't take any config (which it looks like from the Agave PR), we can just do:
Suggested change
| getAlpenglowMigrationSlot(config?: Readonly<object>): GetAlpenglowMigrationSlotApiResponse; | |
| getAlpenglowMigrationSlot(): GetAlpenglowMigrationSlotApiResponse; |
mcintyre94
added
the
do-not-close
Author
|
Thanks for the review @mcintyre94. Looks like we will be making changes to anza-xyz/agave#12735 so we should also wait till we finalise what the exact API will be. |
mcintyre94
marked this pull request as draft
June 12, 2026 15:26
Member
|
Marking draft for now. The method landed as {
"jsonrpc": "2.0",
"result": null || {
"bitmap": [1,2,3,...],
"certType": {
"genesis": {
"blockId": [4,5,6,...],
"slot": 0
}
},
"signature": [7,8,9,...]
},
"id": 1
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In anza-xyz/agave#12735, we are introducing a new rpc endpoint to retrieve the slot in which migration to alpenglow took place.
Summary of Changes
This adds support for the endpoint in this repo