Skip to content

Migrate Airbyte provider to airbyte-api library 1.0 and httpx#68882

Merged
eladkal merged 11 commits into
apache:mainfrom
aaronsteers:airbyte/update/update-to-airbyte-api-1.0
Jul 8, 2026
Merged

Migrate Airbyte provider to airbyte-api library 1.0 and httpx#68882
eladkal merged 11 commits into
apache:mainfrom
aaronsteers:airbyte/update/update-to-airbyte-api-1.0

Conversation

@aaronsteers

@aaronsteers aaronsteers commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Devin.ai following the guidelines

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

devin-ai-integration Bot and others added 3 commits June 23, 2026 06:21
@devin-ai-integration @aaronsteers
fix(providers/airbyte): migrate from requests.Session to httpx.Client…
2cd5a34 
… for airbyte-api>=1.0

airbyte-api 1.0.0rc2 switched its HTTP layer from requests to httpx.
The client parameter now requires an httpx-compatible HttpClient protocol
and no longer accepts requests.Session.

Changes:
- Replace requests.Session proxy setup with httpx.Client(mounts=...)
- Update pyproject.toml: airbyte-api>=1.0.0rc2, httpx>=0.28.1, drop requests
- Update test to assert isinstance(client, httpx.Client) instead of
  checking .proxies attribute (not available on httpx.Client)

Co-Authored-By: AJ Steers <aj@airbyte.io>
@devin-ai-integration @aaronsteers
fix: move httpx import to top-level in test file
c0ed615 
Co-Authored-By: AJ Steers <aj@airbyte.io>
@devin-ai-integration @aaronsteers
fix: strengthen proxy test and bump airbyte-api lower bound to >=1.0.0
24d2287 
- Test now verifies proxy transport mounts are configured per-scheme
- Bump airbyte-api lower bound from >=1.0.0rc2 to >=1.0.0 (GA released)

Co-Authored-By: AJ Steers <aj@airbyte.io>
@boring-cyborg

boring-cyborg Bot commented Jun 23, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Andrushika

Andrushika commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

I encountered the same Airbyte compatibility failure in an unrelated PR, so I took a look here, and this PR seems to be addressing the same underlying issue.

One small Airflow-specific thing: the PR title currently uses a prefix like fix(...), but Airflow’s commit/PR title checks generally expect an imperative-style title without that prefix. Something like Migrate Airbyte provider to airbyte-api 1.0 may work better. The same may apply to the commit messages if the prek hook is failing.

I noticed this is still in draft. If you are short on time, I’d be happy to help!

@shahar1 shahar1 mentioned this pull request Jun 27, 2026
Merged
1 task
@aaronsteers aaronsteers changed the title fix(providers/airbyte): migrate to airbyte-api>=1.0.0rc2 and httpx.Client Migrate Airbyte provider to airbyte-api library 1.0 and httpx Jun 27, 2026
@aaronsteers aaronsteers marked this pull request as ready for review June 27, 2026 20:37
@eladkal

eladkal commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@aaronsteers can you fix the static checks? there are some failures

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

uv.lock on main just moved via #69486 ("Prepare providers release 2026-07-06"), commit d19a68a and this PR currently conflicts.

Quickest fix:

git fetch upstream main && git rebase upstream/main
rm uv.lock && uv lock
git add uv.lock && git rebase --continue
git push --force-with-lease

Automated nudge — ignore if you're not ready to rebase. This comment is updated in place on future uv.lock bumps.

@devin-ai-integration @aaronsteers
Merge origin/main; regenerate airbyte docs without stale cross-provid…
6f84f5c 
…er section

Co-Authored-By: AJ Steers <aj@airbyte.io>
aaronsteers
aaronsteers commented Jul 6, 2026
View reviewed changes
Comment thread providers/airbyte/pyproject.toml
@devin-ai-integration @aaronsteers
Bump airbyte provider to 6.0.0 for breaking airbyte-api 1.0 / httpx m…
f71aa0b 
…igration

Co-Authored-By: AJ Steers <aj@airbyte.io>
@aaronsteers

aaronsteers commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@eladkal - Do you mind approving checks again? I believe we've resolved the failures, and for safety (transitive dependencies changed), I proposed a version bump to 6.0.0, reflecting (at least potentially) breaking changes in this update.

eladkal
eladkal reviewed Jul 7, 2026
View reviewed changes
Comment thread providers/airbyte/docs/changelog.rst Outdated
@devin-ai-integration @aaronsteers
Revert manual airbyte version bump and reframe changelog note as non-…
9bebc50 
…breaking

Per reviewer feedback, this is not an Airflow-code breaking change, so the
version stays release-manager-managed (5.5.2) rather than a hardcoded 6.0.0
bump. The manual 6.0.0 entry in provider.yaml also broke the
prepare-provider-documentation CI step, which diffs against the previous
version tag (providers-airbyte/5.5.2) that is not yet released.

Retitle the changelog section from 'Breaking changes' to 'Transitive
dependency changes' and drop the 6.0.0 header.

Co-Authored-By: AJ Steers <aj@airbyte.io>
@vincbeck vincbeck mentioned this pull request Jul 7, 2026
Closed
75 tasks
eladkal
eladkal approved these changes Jul 7, 2026
View reviewed changes

@eladkal eladkal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge when CI is green

@eladkal

eladkal commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Merging. Static checks failure is not related to this PR

@eladkal eladkal merged commit b21e429 into apache:main Jul 8, 2026
90 of 91 checks passed
@boring-cyborg

boring-cyborg Bot commented Jul 8, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eladkal eladkal eladkal approved these changes
@vincbeck vincbeck vincbeck approved these changes

Assignees

No one assigned

Labels

area:providers provider:airbyte

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaronsteers @Andrushika @eladkal @vincbeck