Stop skipping none_failed_min_one_success tasks in mapped task groups#69377
Open
shahar1 wants to merge 1 commit into
Open
Stop skipping none_failed_min_one_success tasks in mapped task groups#69377shahar1 wants to merge 1 commit into
shahar1 wants to merge 1 commit into
Conversation
A task with the none_failed_min_one_success trigger rule inside a dynamically mapped task group was evaluated on its not-yet-expanded summary task instance (map_index -1). At that point its upstream had already expanded to map indexes 0..n, so the summary evaluation found no relevant upstream successes and skipped the task before it could expand. Extend the "fast-triggered" set that gets broad depend-on-all-upstreams treatment on the unexpanded summary ti to include this rule, alongside the one_success/one_failed/one_done rules already handled there, so the task waits for its upstream and expands instead of skipping. closes: apache#39801
shahar1
force-pushed
the
fix-none-failed-min-one-success-mapped-task-group
branch
from
71611ba to
a9d9fe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human Summary
Considers
none_failed_min_one_successas fast triggered to avoid skipping before Dynamic Task Group is fully expanded.AI Summary
Click here
A task whose trigger rule is `none_failed_min_one_success` and that lives inside a dynamically mapped task group was being **skipped before the task group expanded**, even though its upstream succeeded.The trigger rule is first evaluated on the task's not-yet-expanded summary task instance (
map_index -1). By that point the upstream inside the same group has already expanded tomap_index 0..n, so the summary-ti evaluation finds no relevant upstream successes, concludes "at least one success required, none found", and skips the task — it never expands.one_success/one_failed/one_donealready avoid this by being treated as "fast-triggered" on the unexpanded summary ti (they depend on all upstream instances until the group expands — see #34023 / #50210).none_failed_min_one_successbelongs in that same set: it can be satisfied by a subset of upstreams, so broad depend-on-all-upstreams counting on the summary ti is safe and lets the task expand normally. This PR adds it there.Reproduced on
main(3.4.0) with the issue's minimal Dag (tg.imawakeended upskippedatmap_index -1whiletg.imsleepyexpanded to0,1,2all success); with the fixtg.imawakeexpands to0,1,2and succeeds. Added a regression test that fails on the buggy code and passes with the fix.A prior attempt at this issue (#40428) was closed in 2024; this revives the fix scoped precisely to the affected trigger rule.
closes: #39801
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines