Detect stale metrics registry entries in the metrics sync prek hook#69578
Draft
FrankYang0529 wants to merge 1 commit into
Draft
Detect stale metrics registry entries in the metrics sync prek hook#69578FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
1 task
214a3a6 to
a8e4b57
Compare
Signed-off-by: PoAn Yang <payang@apache.org>
a8e4b57 to
544fd7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
check-metrics-synced-with-registryonly checks one direction: a metric used in code but missing frommetrics_template.yaml.How
git ls-files). It checks any registry entry with no matching metric in code.INDIRECTLY_EMITTED_METRICSallowlist for the threeexecutor.*gauges whose names are built viaBaseExecutor._get_metric_name()and cannot be resolved statically.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.