[chart/v1-2x-test] Improve API server HTTPRoute configuration (#68552)#69579
Open
steveahnahn wants to merge 1 commit into
Open
[chart/v1-2x-test] Improve API server HTTPRoute configuration (#68552)#69579steveahnahn wants to merge 1 commit into
steveahnahn wants to merge 1 commit into
Conversation
steveahnahn
requested review from
Miretpl,
bugraoz93,
hussein-awala,
jedcunningham and
jscheffl
as code owners
1 task
Member
|
Closed/re-opened to re-trigger the jobs after #69626 |
1 task
* Move API server HTTPRoute under apiServer and add config guards * Require HTTPRoute parentRefs and document API server Ingress mutual exclusivity * Fail fast on empty HTTPRoute parentRefs via schema minItems * Apply pretty-format-json formatting to values.schema.json (cherry picked from commit d2d9f4c)
potiuk
force-pushed
the
backport-68552-to-chart-v1-2x
branch
from
9a2cce2 to
59459de
Compare
Contributor
|
I will wait with merge till the CI finishes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #68552
parentRefsenforced via schemaminItemshttpRouteconfiguration underapiServerOne conflict in
chart/templates/api-server/api-server-ingress.yaml: kept this branch's Ingress enablement condition (which retains thesemverCompare/ globalingress.enabledhandling) and applied only the new HTTPRoute mutual-exclusion guard. Verified with the full apiserver helm-test group (125 passed) on this branch.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines