MINOR: Add private constructor to UuidType singleton #945
+42
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmater
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
lidavidm
reviewed
Jan 6, 2026
Member
There was a problem hiding this comment.
All builds fail:
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project arrow-vector: Compilation failure: Compilation failure:
Error: /build/vector/src/main/java/org/apache/arrow/vector/UuidVector.java:[72,52] error: UuidType() has private access in UuidType
Error: /build/vector/src/main/java/org/apache/arrow/vector/UuidVector.java:[102,52] error: UuidType() has private access in UuidType
Author
Thank you for looking into it @lidavidm. |
jbonofre
approved these changes
Jan 9, 2026
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
LGTM.
Do you mind to rebase in order to have CI happy ?
tmater
force-pushed
the
uuidtype_singleton
branch
from
530d5a8 to
cd32ddb
Compare
Author
Thank you for the review! |
Member
|
@tmater thanks ! I just ran the CI, I will merge as soon as it's all green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add private constructor to UuidType singleton.