fix(pydantic): accept union type objects for stream_type hints #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrawcz
reviewed
Jan 4, 2026
Comment on lines
+70
to
+75
| if typing.TYPE_CHECKING: | ||
| StreamingPydanticType = Any | ||
| else: | ||
| StreamingPydanticType = Union[Type["BaseModel"], Type[dict]] | ||
| if UnionType is not None: | ||
| StreamingPydanticType = Union[Type["BaseModel"], Type[dict], UnionType] |
Contributor
There was a problem hiding this comment.
doing Any for typing checking will of course work and is cheating...
I think we shouldn't have a typing.TYPE_CHECKING part here, and instead I think the fix is line 74 + 75.
note I had to do this stream_type: Union[Type["BaseModel"], Type[dict], type, "types.UnionType"], for my pyright in the IDE to not complain -- i.e. the quotes part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing