List free IPs when performing associate IPAddress operation#155
Merged
Conversation
Pearl1594
requested review from
DaanHoogland,
nvazquez,
shwstppr,
weizhouapache and
yadvr
Member
|
nice fix ! |
shwstppr
reviewed
Dec 6, 2024
Contributor
shwstppr
left a comment
shwstppr
left a comment
There was a problem hiding this comment.
Change LGTM but some extra debug logs
shwstppr
approved these changes
Dec 6, 2024
weizhouapache
approved these changes
Dec 6, 2024
winterhazel
approved these changes
Feb 15, 2025
Member
winterhazel
left a comment
winterhazel
left a comment
There was a problem hiding this comment.
Manually tested, looks good
yadvr
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR list free IPs as opposed to the allocated IPs when trying associate an IP to a network
Before fix:
which are the list of allocated IPs:
After fix: