Skip to content

api,server: support templatetype when upload template from local #11682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
Sep 22, 2025

Update 11682: check templatetype

13c7e0c
Select commit
Loading
Failed to load commit list.
Merged

api,server: support templatetype when upload template from local #11682

Update 11682: check templatetype
13c7e0c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 18, 2025 in 1s

17.39% (-0.01%) compared to 8eb6ddd, passed because coverage increased by 0% when compared to adjusted base (17.39%)

View this Pull Request on Codecov

17.39% (-0.01%) compared to 8eb6ddd, passed because coverage increased by 0% when compared to adjusted base (17.39%)

Details

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.39%. Comparing base (8eb6ddd) to head (13c7e0c).

Files with missing lines Patch % Lines
.../cloud/storage/upload/params/UploadParamsBase.java 0.00% 9 Missing ⚠️
...n/java/com/cloud/template/TemplateAdapterBase.java 0.00% 9 Missing ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java 0.00% 3 Missing and 1 partial ⚠️
...d/user/template/GetUploadParamsForTemplateCmd.java 0.00% 3 Missing ⚠️
...ud/storage/upload/params/TemplateUploadParams.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11682      +/-   ##
============================================
- Coverage     17.39%   17.39%   -0.01%     
  Complexity    15285    15285              
============================================
  Files          5889     5889              
  Lines        526183   526201      +18     
  Branches      64242    64242              
============================================
- Hits          91542    91540       -2     
- Misses       424297   424315      +18     
- Partials      10344    10346       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov