Skip to content

CLVM enhancements and fixes#12617

Draft
Pearl1594 wants to merge 5 commits intomainfrom
clvm-enhancements
Draft

CLVM enhancements and fixes#12617
Pearl1594 wants to merge 5 commits intomainfrom
clvm-enhancements

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Feb 9, 2026

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Feb 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.68%. Comparing base (d3e1976) to head (df61d6f).
⚠️ Report is 15 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (d3e1976) and HEAD (df61d6f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d3e1976) HEAD (df61d6f)
unittests 1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##               main   #12617       +/-   ##
=============================================
- Coverage     17.90%    3.68%   -14.23%     
=============================================
  Files          5938      454     -5484     
  Lines        532864    38798   -494066     
  Branches      65192     7151    -58041     
=============================================
- Hits          95392     1428    -93964     
+ Misses       426793    37183   -389610     
+ Partials      10679      187    -10492
Flag Coverage Δ
uitests 3.67% <ø> (+<0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Feb 11, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 11, 2026

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 11, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16801

@harikrishna-patnala harikrishna-patnala added this to the 4.23.0 milestone Feb 17, 2026
weizhouapache
weizhouapache reviewed Feb 17, 2026
View reviewed changes
...apshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java
UserVmVO vm = userVmDao.findById(vmId);
String cantHandleLog = String.format("Default VM snapshot cannot handle VM snapshot for [%s]", vm);

if (isRunningVMVolumeOnCLVMStorage(vm, cantHandleLog)) {
Copy link
Member

@weizhouapache weizhouapache Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pearl1594
what's the image format on CLVM ? RAW or QCOW2 ?

Copy link
Contributor Author

@Pearl1594 Pearl1594 Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAW @weizhouapache

@codecov
Copy link

codecov bot commented Feb 17, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 5.74257% with 476 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.99%. Comparing base (d3e1976) to head (c9dd7ed).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
.../hypervisor/kvm/storage/LibvirtStorageAdaptor.java 0.00% 209 Missing ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 15.88% 88 Missing and 2 partials ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 84 Missing ⚠️
.../storage/vmsnapshot/DefaultVMSnapshotStrategy.java 0.00% 20 Missing ⚠️
...ce/wrapper/LibvirtPostMigrationCommandWrapper.java 9.09% 20 Missing ⚠️
...java/com/cloud/agent/api/PostMigrationCommand.java 0.00% 16 Missing ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 0.00% 14 Missing ⚠️
.../java/com/cloud/agent/api/PostMigrationAnswer.java 0.00% 9 Missing ⚠️
.../storage/vmsnapshot/StorageVMSnapshotStrategy.java 0.00% 5 Missing ⚠️
...resource/wrapper/LibvirtMigrateCommandWrapper.java 66.66% 2 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12617      +/-   ##
============================================
+ Coverage     17.90%   17.99%   +0.09%     
- Complexity    16094    16279     +185     
============================================
  Files          5938     5942       +4     
  Lines        532864   536715    +3851     
  Branches      65192    66425    +1233     
============================================
+ Hits          95392    96596    +1204     
- Misses       426793   429331    +2538     
- Partials      10679    10788     +109
Flag Coverage Δ
uitests 3.67% <ø> (+<0.01%) ⬆️
unittests 19.11% <5.74%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 17, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
3.2% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weizhouapache weizhouapache weizhouapache left review comments

Assignees

No one assigned

Labels

component:api component:compute component:kvm component:orchestration component:storage

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Pearl1594 @blueorangutan @weizhouapache @harikrishna-patnala