Skip to content

API key pair restructure #9504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
Mar 9, 2026

improve log message

b6b1b5f
Select commit
Loading
Failed to load commit list.
Merged

API key pair restructure #9504

improve log message
b6b1b5f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 5, 2026 in 1s

17.92% (+0.00%) compared to 7ad68aa

View this Pull Request on Codecov

17.92% (+0.00%) compared to 7ad68aa

Details

Codecov Report

❌ Patch coverage is 16.50738% with 961 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.92%. Comparing base (7ad68aa) to head (b6b1b5f).

Files with missing lines Patch % Lines
...c/main/java/com/cloud/user/AccountManagerImpl.java 31.80% 182 Missing and 11 partials ⚠️
...he/cloudstack/api/response/ApiKeyPairResponse.java 0.00% 127 Missing ⚠️
...ck/api/command/admin/user/RegisterUserKeysCmd.java 0.00% 94 Missing ⚠️
...n/java/org/apache/cloudstack/acl/ApiKeyPairVO.java 25.60% 93 Missing ⚠️
...src/main/java/com/cloud/api/ApiResponseHelper.java 0.00% 61 Missing ⚠️
...g/apache/cloudstack/acl/dao/ApiKeyPairDaoImpl.java 0.00% 43 Missing ⚠️
...dstack/api/command/admin/user/ListUserKeysCmd.java 0.00% 35 Missing ⚠️
...g/apache/cloudstack/acl/ApiKeyPairManagerImpl.java 0.00% 33 Missing ⚠️
...tack/api/command/admin/user/DeleteUserKeysCmd.java 0.00% 30 Missing ⚠️
.../cloudstack/discovery/ApiDiscoveryServiceImpl.java 14.28% 28 Missing and 2 partials ⚠️
... and 31 more
Additional details and impacted files 
@@            Coverage Diff             @@
##               main    #9504    +/-   ##
==========================================
  Coverage     17.92%   17.92%            
- Complexity    16156    16176    +20     
==========================================
  Files          5939     5949    +10     
  Lines        533192   534058   +866     
  Branches      65239    65301    +62     
==========================================
+ Hits          95591    95748   +157     
- Misses       426859   427553   +694     
- Partials      10742    10757    +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov