Cleanup names phase 4 #689
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only involved mostly public classes.
name changes for Theta.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Note that I focused on changing the name of public classes where they might conflict with similarly named classes in other families, particularly the /theta/ and /tuple/ families.
src/main/java/org/apache/datasketches/tuple/TupleSketch.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/org/apache/datasketches/tuple/TupleSketch.java
Dismissed
Show dismissed
Hide dismissed
src/test/java/org/apache/datasketches/tuple/adouble/AdoubleTest.java
Dismissed
Show dismissed
Hide dismissed
src/test/java/org/apache/datasketches/tuple/aninteger/IntegerSketchTest.java
Dismissed
Show dismissed
Hide dismissed
src/test/java/org/apache/datasketches/tuple/strings/ArrayOfStringsSketchTest.java
Dismissed
Show dismissed
Hide dismissed
Contributor
Author
|
See last comment in PR 690 |
leerho
requested review from
AlexanderSaydakov,
c-dickens,
freakyzoidberg and
jmalkin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dedicated to changing the names of classes to include the sketch family in the name to avoid confusion with other similarly named classes in other sketch families. There are no code logic changes in /main/. There are a few fixes in /test/ where Pilot was complaining about unused variables.
As in /theta/ the Sketches class in /tuple/ as been removed by moving the 4 existing static methods into the new TupleSketch class.
Changing names involves lots of classes and there is no question that changing names is a breaking change. But we had to choose a time to do it, and the big move to FFM was a good time to do this as well.
The primary sketch families affected are /theta/, /tuple/, /frequency/, (classic) /quantiles/