Provide a way to merge Kll sketches deterministically #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I am not in favor of this behavior. It is nearly always the wrong thing for users to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #693, it would be very helpful for certain downstream projects to be able to use the KLL sketches, while still getting a deterministic result.
This PR proposes to add a method
KllSketch#merge(KllSketch, Random)as an alternative. Existing code will continue to run as before. New callers can consider to use the newly added method if they need deterministic results. A warning has been added to the javadoc of the new method, to make it clear that the error guarantees of the KLL sketch algorithm might no longer be valid.