[fix](cloud) modify delete_bitmap_store_v2_max_bytes_in_fdb - #67494
[fix](cloud) modify delete_bitmap_store_v2_max_bytes_in_fdb#67494mymeiyi wants to merge 1 commit into
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward config default adjustment with a minor maintainability nit around documenting the rationale/units for the new magic number.
Pull request overview
This PR adjusts the default Cloud BE configuration for when delete-bitmap Store V2 data should be kept directly in FoundationDB versus spilled to external storage, choosing a larger threshold intended to reduce overhead for large delete bitmaps and align with existing blob chunking behavior.
Changes:
- Updated
delete_bitmap_store_v2_max_bytes_in_fdbdefault from1024to90000. - Added an inline comment noting the intended alignment with
blob_putsplit sizing.
Review Checkpoints (per Doris checklist)
- Goal & correctness: The change matches the stated intent of increasing the threshold to avoid performance regressions from too-small limits; no functional logic changes beyond default behavior.
- Scope/focus: Small and focused (single config default + comment).
- Concurrency / lifecycle: Not applicable (config definition only).
- Config behavior: This is a default behavior change (more delete-bitmaps may be stored in FDB by default); the chosen number should be clearly justified in-code because it impacts operational characteristics.
- Test coverage: Existing regression suites reference this config, but they set it explicitly in test sessions; the new default itself is not directly covered by those tests.
File summaries
| File | Description |
|---|---|
| be/src/cloud/config.cpp | Raises the default delete-bitmap Store V2 “max bytes in FDB” threshold to 90,000 and documents intended alignment with blob_put chunking. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // same as split_size of blob_put | ||
| DEFINE_mInt64(delete_bitmap_store_v2_max_bytes_in_fdb, "90000"); |
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
In test, a 64 KiB threshold reduces performance by 6% for large bitmaps, while 128 KiB shows no measurable slowdown. And consider split_size in blob_put, set to 90000.