[fix](pipeline) Reject mismatched pipeline task counts - #67499
Open
Mryange wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve?
Issue Number: N/A
Problem Summary: Non-local-exchange operators that split a plan node across two pipelines require one-to-one sink and source tasks. A mismatched task count can leave the paired source dependency uninitialized and crash later during pipeline execution. Validate every in-fragment sink destination after local exchange planning and reject mismatched task counts before pipeline preparation and task creation. Local exchanges remain exempt because they intentionally redistribute between different concurrency levels.
### Release note
Reject invalid pipeline plans with mismatched sink and source task counts before execution.
### Check List (For Author)
- Test: Manual test
- Built BE and FE successfully.
- Ran the original RQG SQL with its session variables and verified the mismatch is rejected before execution while FE and BE remain alive.
- Focused unit tests were added but not run separately.
- Behavior changed: Yes. Invalid non-local-exchange pipeline task counts now return an internal error before execution.
- Does this need documentation: No.
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline-breaking operators require matching sink and source task counts unless a local exchange explicitly redistributes concurrency. A mismatch could leave source dependencies uninitialized and crash during execution. This change validates all in-fragment sink/source pairs after local exchange planning and rejects invalid plans before PipelineTask creation.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)