fix(pipeline): limit streaming aggregation memory without spill - #67501
Open
JackyWoo wants to merge 1 commit into
Open
fix(pipeline): limit streaming aggregation memory without spill#67501JackyWoo wants to merge 1 commit into
JackyWoo wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
spill_streaming_agg_mem_limit(default 256MB) was only applied when query-levelspill was enabled (
enable_spill = true). When spill is disabled — which is stilla common deployment — the streaming aggregation operator now only limit the hastable by
row count but not data size, which may causing OOM on query with large agg_state queries.
Release note
None
Check List (For Author)
Test
Behavior changed:
Limit streaming aggregation memory without spill.
The value of
spill_streaming_agg_mem_limitis a tradeoff between query time and memory.The following is a query in my prodoction env.
Check List (For Reviewer who merge this PR)