[feat](cloud) Expose approximate rowset metric - #67502
Open
jayakasadev wants to merge 3 commits into
Open
Conversation
### What problem does this PR solve? Issue Number: close apache#67458 Related PR: N/A Problem Summary: Cloud write admission checks each tablet's _approximate_num_rowsets, but Prometheus exposed only the materialized version-count distribution and omitted recently accessed tablets. Register a separate histogram from the exact admission counter before the inactive-tablet filter so active tablets are included. A focused unit test verifies an active tablet is excluded from the existing report yet included in the new metric. ### Release note Add tablet_approximate_num_rowsets_distribution for cloud-mode tablet version-limit monitoring. ### Check List (For Author) - Test: Header hygiene and formatting checks passed. Focused BE unit test was attempted but local configuration cannot proceed without third-party artifacts; Docker build image extraction also fails on this host. - Behavior changed: Yes. Cloud BEs expose a new Prometheus histogram. - Does this need documentation: No.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
jayakasadev
changed the title
Author
|
run buildall |
Set a nonzero inactive-report window in the approximate-rowsets metric test so the test tablet takes the active-tablet path. Restore the global after the assertion to avoid changing later tests.
Author
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #67458
Related PR: N/A
Problem Summary:
TOO_MANY_VERSIONerrors when a tablet has too many versions. The code checks_approximate_num_rowsets, but its not emitted as a metric.tablet_version_num_distributionis similar, but it updates less frequently and skips tablets that are currently being written totablet_approximate_num_rowsets_distributionwhich uses_approximate_num_rowsetsand includes active tabletsTOO_MANY_VERSIONerrorsRelease note
Add
tablet_approximate_num_rowsets_distributionfor cloud-mode tablet version-limit monitoringCheck List (For Author)
Test
CloudTabletMgrTest.TestApproximateRowsetsMetricIncludesActiveTablets.build-support/clang-format.shbuild-support/check-format.shbuild-support/check-build-hygiene.shgit diff --checkBehavior changed:
tablet_approximate_num_rowsets_distributionPrometheus histogram.Does this need documentation?
Check List (For Reviewer who merge this PR)