[fix](binlog) Fix row binlog recovery for multi-tablet transactions - #67508
Open
luwei16 wants to merge 1 commit into
Open
[fix](binlog) Fix row binlog recovery for multi-tablet transactions#67508luwei16 wants to merge 1 commit into
luwei16 wants to merge 1 commit into
Conversation
### What problem does this PR solve? Issue Number: close apache#67091 Related PR: None Problem Summary: A BE restart indexed row-binlog rowsets only by transaction ID, so multiple tablet pairs in one transaction could attach the wrong companion rowset. Persist each base tablet's companion ID and recover using both transaction and tablet IDs. ### Release note Fix incorrect row-binlog companion recovery after a BE restart for multi-tablet transactions. ### Check List (For Author) - Test: Unit Test - Added and ran GroupRowsetBuilderTest.recoverMultipleRowBinlogPairsInOneTxn and GroupRowsetBuilderTest.* - Behavior changed: Yes. BE restart recovery now attaches each base rowset to its persisted companion tablet. - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 16734 ms |
Contributor
TPC-DS: Total hot run time: 81861 ms |
Contributor
ClickBench: Total hot run time: 14.72 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #67091
Related PR: None
Problem Summary: A BE restart indexed row-binlog rowsets only by transaction ID, so multiple tablet pairs in one transaction could attach the wrong companion rowset. Persist each base tablet's companion ID and recover using both transaction and tablet IDs.
Release note
Fix incorrect row-binlog companion recovery after a BE restart for multi-tablet transactions.
Check List (For Author)