[fix](fe) Use updated Routine Load CSV parser properties - #67509
Open
0AyanamiRei wants to merge 1 commit into
Open
[fix](fe) Use updated Routine Load CSV parser properties#675090AyanamiRei wants to merge 1 commit into
0AyanamiRei wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Routine Load kept CSV enclose and escape values in both the persisted job properties and separate in-memory byte fields. ALTER ROUTINE LOAD updated only the persisted properties, so newly planned tasks continued using the parser configuration from CREATE ROUTINE LOAD. Make jobProperties the single job-level source of truth and derive the parser bytes when creating Kafka and Kinesis task snapshots.
### Release note
ALTER ROUTINE LOAD now applies updated CSV enclose and escape characters to subsequent tasks.
### Check List (For Author)
- Test: Unit Test / Regression test
- Unit Test: KafkaRoutineLoadJobTest (12 tests passed)
- Regression test: Extended test_routine_load_property; not run locally because the configured Kafka test service is unavailable
- Behavior changed: Yes. New Routine Load tasks use CSV enclose and escape values changed by ALTER.
- Does this need documentation: No
0AyanamiRei
force-pushed
the
fix-routine-load-csv-alter-cache
branch
from
September 3, 2026 18:17
db729be to
6e7bc6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
RoutineLoadJobkept CSVencloseandescapevalues in both persistedjobPropertiesand separate in-memory byte fields.ALTER ROUTINE LOADupdated onlyjobProperties, while newly planned Kafka and Kinesis tasks used the stale fields fromCREATE ROUTINE LOAD.This change makes persisted
jobPropertiesthe single job-level source of truth.RoutineLoadJobderives the parser bytes through its getters, and each new task receives a snapshot of the current values. ALTER execution, journal replay, and checkpoint loading already preservejobProperties, so no load-description replay or checkpoint-specific repair is needed.Release note
ALTER ROUTINE LOADnow applies updated CSVencloseandescapecharacters to subsequent tasks.Check List (For Author)
Unit test executed:
DORIS_THIRDPARTY=/path/to/thirdparty-with-thrift-0.24.0 ./run-fe-ut.sh --run org.apache.doris.load.routineload.KafkaRoutineLoadJobTestResult: 12 tests passed.
The Kafka regression test truncates the table after ALTER and publishes a row that requires the new
encloseandescapevalues while preserving the existing deterministic expected output. It was not run locally because the configured Kafka regression service is unavailable; CI will run it in the Kafka-enabled environment.Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)