Revert "[VL][Iceberg] Register iceberg spark session extensions automatically" - #12913
Open
zhouyuan wants to merge 1 commit into
Open
Revert "[VL][Iceberg] Register iceberg spark session extensions automatically"#12913zhouyuan wants to merge 1 commit into
zhouyuan wants to merge 1 commit into
Conversation
…atically…" This reverts commit 0364eaf.
This was referenced Aug 27, 2026
jackylee-ch
approved these changes
Aug 27, 2026
infvg
approved these changes
Aug 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Reverts automatic registration of Iceberg Spark session extensions by the Gluten plugin/components, shifting responsibility back to explicit Spark config in Iceberg tests and simplifying extension handling in the driver plugin.
Changes:
- Removes component-provided Spark SQL session extensions support (
sparkSessionExtensions) fromComponentand Velox Iceberg component. - Updates driver plugin to only ensure Gluten’s own session extension is present, without merging component extensions.
- Adjusts Iceberg test configuration to explicitly set Iceberg Spark SQL extensions and drops a test that asserted plugin-based registration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| gluten-ut/test/src/test/scala/org/apache/gluten/GlutenSessionExtensionsSuite.scala | Deletes a suite that validated “append once” behavior for configured + component + Gluten session extensions. |
| gluten-iceberg/src/test/scala/org/apache/gluten/execution/IcebergSuite.scala | Explicitly configures Iceberg Spark SQL extensions; removes a test that depended on plugin-driven registration. |
| gluten-core/src/main/scala/org/apache/gluten/component/Component.scala | Removes the sparkSessionExtensions() hook from the component API. |
| gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala | Simplifies session-extension configuration to only add Gluten’s extension if missing; removes component-merge helper. |
| backends-velox/src-iceberg/main/scala/org/apache/gluten/component/VeloxIcebergComponent.scala | Removes Iceberg session-extension registration via component; leaves runtime compatibility check. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
79
to
84
| def info(): Map[String, String] = Map.empty | ||
| def dependencies(): Seq[Class[_ <: Component]] | ||
|
|
||
| def sparkSessionExtensions(): Seq[String] = Nil | ||
|
|
||
| /** Spark listeners. */ | ||
| def onDriverStart(sc: SparkContext, pc: PluginContext): Unit = {} | ||
| def onDriverShutdown(): Unit = {} |
Comment on lines
+54
to
+59
| val extensionSeq = conf.get(SPARK_SESSION_EXTENSIONS).getOrElse(Seq.empty) | ||
| if (!extensionSeq.toSet.contains(GlutenSessionExtensions.GLUTEN_SESSION_EXTENSION_NAME)) { | ||
| conf.set( | ||
| SPARK_SESSION_EXTENSIONS, | ||
| extensionSeq :+ GlutenSessionExtensions.GLUTEN_SESSION_EXTENSION_NAME) | ||
| } |
Comment on lines
+40
to
45
| .set( | ||
| "spark.sql.extensions", | ||
| "org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions") | ||
| .set("spark.sql.catalog.spark_catalog", "org.apache.iceberg.spark.SparkCatalog") | ||
| .set("spark.sql.catalog.spark_catalog.type", "hadoop") | ||
| .set("spark.sql.catalog.spark_catalog.warehouse", s"file://$rootPath/tpch-data-iceberg-velox") |
| .set("spark.sql.catalog.spark_catalog.type", "hadoop") | ||
| .set("spark.sql.catalog.spark_catalog.warehouse", s"file://$rootPath/tpch-data-iceberg-velox") | ||
| } | ||
|
|
Comment on lines
+54
to
+59
| val extensionSeq = conf.get(SPARK_SESSION_EXTENSIONS).getOrElse(Seq.empty) | ||
| if (!extensionSeq.toSet.contains(GlutenSessionExtensions.GLUTEN_SESSION_EXTENSION_NAME)) { | ||
| conf.set( | ||
| SPARK_SESSION_EXTENSIONS, | ||
| extensionSeq :+ GlutenSessionExtensions.GLUTEN_SESSION_EXTENSION_NAME) | ||
| } |
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #12823