[VL][UT] Add the iceberg jar when the iceberg profile is selected - #12914
Open
infvg wants to merge 2 commits into
Open
[VL][UT] Add the iceberg jar when the iceberg profile is selected#12914infvg wants to merge 2 commits into
infvg wants to merge 2 commits into
Conversation
…atically…" This reverts commit 0364eaf.
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Aligns UT execution with CI’s iceberg profile by ensuring Iceberg is present on the test classpath and by adjusting how Spark SQL extensions are configured/validated under Iceberg-enabled runs.
Changes:
- Adds an
icebergMaven profile ingluten-utthat pulls iniceberg-spark-runtimewithtestscope. - Stops wiring Spark SQL extensions via
Component/driver-plugin aggregation; Iceberg-specific tests setspark.sql.extensionsexplicitly. - Removes UT coverage around “component session extensions are appended once”.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| gluten-ut/test/src/test/scala/org/apache/gluten/GlutenSessionExtensionsSuite.scala | Removes a UT that validated session-extension merging/dedup behavior. |
| gluten-ut/pom.xml | Adds iceberg profile to include Iceberg runtime on the UT test classpath. |
| gluten-iceberg/src/test/scala/org/apache/gluten/execution/IcebergSuite.scala | Explicitly enables Iceberg Spark SQL extensions in test SparkConf; drops a procedure-registration test. |
| gluten-core/src/main/scala/org/apache/gluten/component/Component.scala | Removes sparkSessionExtensions() from the component API. |
| gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala | Changes driver init to only ensure Gluten’s extension is present (no component-driven extensions). |
| backends-velox/src-iceberg/main/scala/org/apache/gluten/component/VeloxIcebergComponent.scala | Removes component-provided session extension; keeps runtime-compat check via class presence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+53
to
+59
| // Spark SQL extensions | ||
| val extensionSeq = conf.get(SPARK_SESSION_EXTENSIONS).getOrElse(Seq.empty) | ||
| if (!extensionSeq.toSet.contains(GlutenSessionExtensions.GLUTEN_SESSION_EXTENSION_NAME)) { | ||
| conf.set( | ||
| SPARK_SESSION_EXTENSIONS, | ||
| extensionSeq :+ GlutenSessionExtensions.GLUTEN_SESSION_EXTENSION_NAME) | ||
| } |
Comment on lines
79
to
84
| def info(): Map[String, String] = Map.empty | ||
| def dependencies(): Seq[Class[_ <: Component]] | ||
|
|
||
| def sparkSessionExtensions(): Seq[String] = Nil | ||
|
|
||
| /** Spark listeners. */ | ||
| def onDriverStart(sc: SparkContext, pc: PluginContext): Unit = {} | ||
| def onDriverShutdown(): Unit = {} |
Comment on lines
+53
to
+59
| // Spark SQL extensions | ||
| val extensionSeq = conf.get(SPARK_SESSION_EXTENSIONS).getOrElse(Seq.empty) | ||
| if (!extensionSeq.toSet.contains(GlutenSessionExtensions.GLUTEN_SESSION_EXTENSION_NAME)) { | ||
| conf.set( | ||
| SPARK_SESSION_EXTENSIONS, | ||
| extensionSeq :+ GlutenSessionExtensions.GLUTEN_SESSION_EXTENSION_NAME) | ||
| } |
Comment on lines
+40
to
+42
| .set( | ||
| "spark.sql.extensions", | ||
| "org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions") |
Comment on lines
+31
to
+32
| SparkReflectionUtil.isClassPresent( | ||
| "org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions") |
Comment on lines
+205
to
+207
| <activation> | ||
| <activeByDefault>false</activeByDefault> | ||
| </activation> |
infvg
marked this pull request as ready for review
August 27, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Iceberg runtime is declared as provided and is therefore absent from gluten-ut’s test classpath. This leaves the Iceberg component inactive even when CI enables the Iceberg profile.
This PR adds the runtime as a test-scoped dependency so CI exercises sessions where Iceberg is present and can detect iceberg+unrelated component regressions such as #12912. This also makes it simulate a more realistic production environment where iceberg is present but not being used.