[VL] Refactor HashTableBuilder to use Velox API - #12923
Merged
Merged
Conversation
marin-ma
approved these changes
Aug 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Gluten’s Velox hash join build path to rely on newly available Velox-side helpers, reducing local duplicated logic and addressing a compiler warning in the JNI builder.
Changes:
- Switch
HashTableBuilderto call Velox-providedexec::hashJoinTableTypeandexec::isLeftNullAwareJoinWithFilterinstead of maintaining local equivalents. - Fix a
-Wpessimizing-movewarning inVeloxJniWrapperby removing an unnecessarystd::moveon a temporaryunique_ptrreturn value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/velox/operators/hashjoin/HashTableBuilder.cc | Removes local helper implementations and calls the corresponding Velox exec APIs for join table type construction and null-aware join handling. |
| cpp/velox/jni/VeloxJniWrapper.cc | Removes redundant std::move to avoid pessimizing-move warning when assigning the uniqueTable() return value. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
JkSelf
force-pushed
the
refactor-hashtablebuilder
branch
from
August 28, 2026 13:42
d2578b6 to
cc66e36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How was this patch tested?
Existing unit tests
Was this patch authored or co-authored using generative AI tooling?
No