Skip to content

FIX: remove deprecated pandas CSV reader args (keep_date_col, verbose, delim_whitespace) #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iprithv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FIX: remove deprecated pandas CSV reader args (keep_date_col, verbose, delim_whitespace) #1418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions hamilton/plugins/pandas_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,14 +205,10 @@ def _get_loading_kwargs(self) -> Dict[str, Any]:
kwargs["keep_default_na"] = self.keep_default_na
if self.na_filter is not None:
kwargs["na_filter"] = self.na_filter
if self.verbose is not None:
kwargs["verbose"] = self.verbose
if self.skip_blank_lines is not None:
kwargs["skip_blank_lines"] = self.skip_blank_lines
if self.parse_dates is not None:
kwargs["parse_dates"] = self.parse_dates
if self.keep_date_col is not None:
kwargs["keep_date_col"] = self.keep_date_col
if self.date_format is not None:
kwargs["date_format"] = self.date_format
if self.dayfirst is not None:
Expand Down Expand Up @@ -247,8 +243,6 @@ def _get_loading_kwargs(self) -> Dict[str, Any]:
kwargs["dialect"] = self.dialect
if self.on_bad_lines is not None:
kwargs["on_bad_lines"] = self.on_bad_lines
if self.delim_whitespace is not None:
kwargs["delim_whitespace"] = self.delim_whitespace
if self.low_memory is not None:
kwargs["low_memory"] = self.low_memory
if self.memory_map is not None:
Expand Down
Loading