HPACK: reject integer decoding overflow#627
Merged
arturobernalg merged 1 commit intoapache:masterfrom Feb 19, 2026
Merged
Conversation
ok2c
approved these changes
Feb 19, 2026
Guard HPACK integer decoding against signed overflow and throw HPackException instead. Adds a regression test for crafted values exceeding Integer.MAX_VALUE.
arturobernalg
force-pushed
the
overflow
branch
from
38a6145 to
168878a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change hardens HPACK integer decoding against signed int overflow.
When decoding continuation bytes, the accumulated value can exceed Integer.MAX_VALUE and wrap negative,
which may surface later as unchecked exceptions (e.g. invalid index / length) instead of a clean
HPackException.