HTTP/2: fix frame header parsing and validate SETTINGS ACK length#628
Merged
arturobernalg merged 1 commit intoapache:masterfrom Feb 20, 2026
Merged
HTTP/2: fix frame header parsing and validate SETTINGS ACK length#628arturobernalg merged 1 commit intoapache:masterfrom
arturobernalg merged 1 commit intoapache:masterfrom
Conversation
ok2c
requested changes
Feb 19, 2026
| throw new H2ConnectionException(H2Error.FRAME_SIZE_ERROR, "Frame size exceeds maximum"); | ||
| } | ||
|
|
||
| if (type == FrameType.SETTINGS.getValue() && (flags & FrameFlag.ACK.getValue()) != 0 && payloadLen != 0) { |
Member
There was a problem hiding this comment.
@arturobernalg This is the wrong place and not the buffer's job to validate frames. Move this check to the protocol handler.
Member
Author
There was a problem hiding this comment.
@arturobernalg This is the wrong place and not the buffer's job to validate frames. Move this check to the protocol handler.
@ok2c yeah. The check of the payloadLen > maxFramePayloadSize make me doubt and i put it there. I just moved.
arturobernalg
force-pushed
the
setting-ack
branch
from
1347496 to
e74b16e
Compare
Parse the 24-bit Length field as an unsigned value, treat flags as an unsigned byte, and mask out the reserved bit from the Stream Identifier. Also enforce RFC 9113 §6.5: SETTINGS frames with ACK set MUST have an empty payload (Length = 0); otherwise raise FRAME_SIZE_ERROR.
arturobernalg
force-pushed
the
setting-ack
branch
from
e74b16e to
28de099
Compare
ok2c
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse the 24-bit Length field as an unsigned value, treat flags as an unsigned byte, and mask out the reserved bit from the Stream Identifier.
Also enforce RFC 9113 §6.5: SETTINGS frames with ACK set MUST have an empty payload (Length = 0); otherwise raise FRAME_SIZE_ERROR.