ResponseConformance: enforce no-entity rules for 1xx and 205#630
Closed
arturobernalg wants to merge 1 commit intoapache:masterfrom
Closed
ResponseConformance: enforce no-entity rules for 1xx and 205#630arturobernalg wants to merge 1 commit intoapache:masterfrom
arturobernalg wants to merge 1 commit intoapache:masterfrom
Conversation
RFC 9110 requires that 1xx responses “cannot contain content or trailers” and that 205 responses MUST NOT generate content.
ok2c
reviewed
Feb 20, 2026
| if (entity != null) { | ||
| throw new ProtocolException("Response " + status + " must not enclose an entity"); | ||
| } | ||
| if (status >= 100 && status < 200 |
Member
There was a problem hiding this comment.
@arturobernalg This is unnecessary. 1xx responses never get processed by the protocol interceptors. Their life-cycle is completely separate.
Member
Author
|
@ok2c your absolutely right. sorry about that. And you had already mentioned it before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResponseConformance now rejects EntityDetails for 1xx and 205 responses.
RFC 9110 15.2: “A 1xx response is terminated by the end of the header section; it cannot contain content or trailers.”
RFC 9110 15.3.6: “... a server MUST NOT generate content in a 205 response.”