feat: add AstMemoryEstimator for SQL AST memory estimation #16882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackieTien97
requested changes
Dec 11, 2025
Contributor
JackieTien97
left a comment
JackieTien97
left a comment
There was a problem hiding this comment.
IMO, making Node implements Accountable interface may be the best way.
| } | ||
|
|
||
| private void addNodeSize(Node node) { | ||
| totalMemorySize += RamUsageEstimator.shallowSizeOfInstance(node.getClass()); |
Contributor
There was a problem hiding this comment.
Node's InstanceSize should be a constant, no need to calculate each time.
| import java.util.Optional; | ||
|
|
||
| /** Utility class for estimating memory usage of AST nodes. */ | ||
| public final class AstMemoryEstimator { |
Contributor
There was a problem hiding this comment.
It's hard to maintain this class, if any Node has some changes or new Node being added.
…are-ast # Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/LoadTsFile.java
JackieTien97
requested changes
Dec 15, 2025
...ava/org/apache/iotdb/db/schemaengine/schemaregion/read/resp/info/impl/ShowDevicesResult.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/iotdb/db/schemaengine/schemaregion/read/resp/info/impl/ShowDevicesResult.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/AstMemoryEstimationHelper.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/ColumnDefinition.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/AliasedRelation.java
Outdated
Show resolved
Hide resolved
...node/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/SingleColumn.java
Outdated
Show resolved
Hide resolved
...ore/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/Trim.java
Outdated
Show resolved
Hide resolved
...anode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/UnloadModel.java
Outdated
Show resolved
Hide resolved
...e/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/Update.java
Outdated
Show resolved
Hide resolved
...atanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/WithQuery.java
Outdated
Show resolved
Hide resolved
JackieTien97
requested changes
Dec 15, 2025
Contributor
JackieTien97
left a comment
JackieTien97
left a comment
There was a problem hiding this comment.
Remember to review the codes by yourself if the codes are mostly generated by LLM.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds memory estimation capabilities for SQL AST (Abstract Syntax Tree) nodes by implementing the Accountable interface across the codebase. The feature enables tracking memory usage of parsed SQL statements through the ramBytesUsed() method, which is useful for memory management and resource planning.
Key Changes:
- Implements
Accountableinterface on the baseNodeandJoinCriteriaclasses - Adds
ramBytesUsed()method implementations to 100+ AST node classes - Introduces comprehensive test suite with 80+ test cases covering various SQL constructs
- Adds
getLocationInternal()accessor method toNodeclass for memory estimation
Reviewed changes
Copilot reviewed 207 out of 207 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AstMemoryEstimatorTest.java | New comprehensive test suite with 80+ tests covering literals, expressions, queries, and complex SQL statements |
| Node.java | Base class updated to implement Accountable and add getLocationInternal() method |
| JoinCriteria.java | Updated to implement Accountable interface |
| QualifiedName.java | Implements Accountable with memory estimation logic for qualified names |
| ShowDevicesResult.java | Adds Accountable implementation for schema result objects |
| 100+ AST classes | Each implements ramBytesUsed() using consistent pattern: INSTANCE_SIZE + field sizes |
| AbstractTraverseDevice.java | Adds getter method for attributeColumns field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rectly call the methods of RamUsageEstimator
…are-ast # Conflicts: # pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.