Introduce delay analyzer to get watermark between sequence data and unsequece data based on ICDE 2022 #16886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt2594838
reviewed
Dec 9, 2025
Comment on lines
+373
to
+375
| /** Delay analyzer for tracking data arrival delays and calculating safe watermarks */ | ||
| private final DelayAnalyzer delayAnalyzer; | ||
|
|
Contributor
There was a problem hiding this comment.
Add a switch for this to avoid affecting performance of existing scenarios.
Comment on lines
+71
to
+80
| /** Default window size, empirical value: 10000 sample points */ | ||
| public static final int DEFAULT_WINDOW_SIZE = 10000; | ||
|
|
||
| /** Recommended window size range */ | ||
| public static final int MIN_WINDOW_SIZE = 1000; | ||
|
|
||
| public static final int MAX_WINDOW_SIZE = 100000; | ||
|
|
||
| /** Default confidence level: 99% */ | ||
| public static final double DEFAULT_CONFIDENCE_LEVEL = 0.99; |
Contributor
There was a problem hiding this comment.
better to add as some configurations.
Comment on lines
+130
to
+134
| @TestOnly | ||
| public DelayAnalyzer(int windowSize, int placeHolder) { | ||
| this.windowSize = windowSize; | ||
| this.delaySamples = new long[windowSize]; | ||
| } |
Contributor
There was a problem hiding this comment.
May use a static method instead of adding a hard-to-understand placeHolder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
details can be referred from comments in code