Fix segment-specific TermInSetQuery rewrites thrashing caching policy#15441
Open
GovindBalaji-S-Glean wants to merge 3 commits intoapache:mainfrom
Open
Fix segment-specific TermInSetQuery rewrites thrashing caching policy#15441GovindBalaji-S-Glean wants to merge 3 commits intoapache:mainfrom
GovindBalaji-S-Glean wants to merge 3 commits intoapache:mainfrom
Conversation
Fixes apache#14986. A `TermInSetQuery` with `rewriteMethod = MultiTermQuery.CONSTANT_SCORE_BLENDED_REWRITE` creates a `RewritingWeight`. Getting a scorer from this `RewritingWeight` for a segment could involve rewriting to a `BooleanQuery` of multiple `TermQuery` with only the terms present in that particular segment. These segment-specific `BooleanQuery` rewrites all thrash the `UsageTrackingQueryCachingPolicy` ring buffer, which is shared across all segments of the index. The expectation is that we mark a query only once per shard in this ring buffer - [ref](https://github.com/apache/lucene/blob/a3fa283cfd6aefbcc5a4983e065da0ce7d3209fe/lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java#L686-L688) In this change: When initializing `AbstractMultiTermQueryConstantScoreWrapper.RewritingWeight`, we copy the supplied indexSearcher but with `setQueryCache(null)` and pass it along for the segment-specific rewrites.
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14986.
A
TermInSetQuerywithrewriteMethod = MultiTermQuery.CONSTANT_SCORE_BLENDED_REWRITEcreates aRewritingWeight. Getting a scorer from thisRewritingWeightfor a segment could involve rewriting to aBooleanQueryof multipleTermQuerywith only the terms present in that particular segment.These segment-specific
BooleanQueryrewrites all thrash theUsageTrackingQueryCachingPolicyring buffer, which is shared across all segments of the index. The expectation is that we mark a query only once per shard in this ring buffer - refIn this change: When initializing
AbstractMultiTermQueryConstantScoreWrapper.RewritingWeight, we copy the supplied indexSearcher but withsetQueryCache(null)and pass it along for the segment-specific rewrites. The subsequent rewrites into BooleanQuery of TermQuery don't go through the query cache (The idea is that these should be cached as the parent TermInSet query itself)