Upgrade plugin dependencies (extra-enforcer-rules) in mvnup#12051
Open
gnodet wants to merge 1 commit into
Open
Upgrade plugin dependencies (extra-enforcer-rules) in mvnup#12051gnodet wants to merge 1 commit into
gnodet wants to merge 1 commit into
Conversation
extra-enforcer-rules versions before 1.4 use DependencyGraphBuilder .buildDependencyGraph(MavenProject, ArtifactFilter) which was removed in Maven 4. The mvnup plugin upgrade strategy now also checks and upgrades dependencies declared inside plugin configurations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mvnuporg.codehaus.mojo:extra-enforcer-rulesto minimum version 1.4 for Maven 4 compatibilityProblem
extra-enforcer-rulesversions before 1.4 useDependencyGraphBuilder.buildDependencyGraph(MavenProject, ArtifactFilter)— a method removed in Maven 4. This causesNoSuchMethodErrorat runtime when rules likeBanCircularDependenciesare executed.Found during maven4-testing across ~960 Apache repositories (e.g., rocketmq uses
extra-enforcer-rules:1.0-beta-4).Version 1.4 switched to
buildDependencyGraph(ProjectBuildingRequest, ArtifactFilter)which is compatible with Maven 4.Changes
PluginUpgradeStrategy: AddedPLUGIN_DEPENDENCY_UPGRADESlist andupgradePluginDependencies()method that checks<dependencies>inside<plugin>elementsupgradePluginVersion()for version comparison and property handlingTest plan
extra-enforcer-rules:1.0-beta-4to1.4extra-enforcer-rules:1.8.0(already sufficient)Claude Code on behalf of Guillaume Nodet