Skip to content

[MDEP-590] Resolve classified POM artifacts from the reactor [4.0.x] - #12831

Merged
gnodet merged 2 commits into
apache:maven-4.0.xfrom
wilx:backport-12658-to-maven-4.0.x
Aug 26, 2026
Merged

[MDEP-590] Resolve classified POM artifacts from the reactor [4.0.x]#12831
gnodet merged 2 commits into
apache:maven-4.0.xfrom
wilx:backport-12658-to-maven-4.0.x

Conversation

@wilx

@wilx wilx commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Description

Backport of #12658 from master to maven-4.0.x.

ReactorReader currently returns the reactor project's build POM for every artifact whose extension is pom, without considering its classifier. Consequently, resolving an attached classified POM from the reactor returns pom.xml instead of the attached artifact.

This change limits the build-POM shortcut to unclassified POM requests. Classified POMs proceed through the existing artifact matching path, which selects the attached artifact by extension and classifier. Ordinary reactor POM and consumer-POM resolution remain unchanged.

The production change is patch-identical to #12658. The Core IT uses the File/String-based verifier API and suite-order registration required by the maven-4.0.x test harness.

Fixes apache/maven-dependency-plugin#1024

Tests

  • Full root clean verify: all 38 modules passed with Maven 3.9.16 and Java 17.
  • spotless:apply: no formatting changes.
  • Focused MavenITmdep0590ClassifiedPomArtifactFromReactorTest against the freshly built Maven 4.0.0-SNAPSHOT distribution: 1 test, 0 failures, 0 errors, 0 skipped.

@gnodet gnodet added this to the 4.0.0-rc-7 milestone Aug 26, 2026
@gnodet gnodet added bug Something isn't working backport labels Aug 26, 2026
@gnodet
gnodet merged commit b83b379 into apache:maven-4.0.x Aug 26, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants