[MDEP-590] Resolve classified POM artifacts from the reactor [4.0.x] - #12831
Merged
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
Description
Backport of #12658 from
mastertomaven-4.0.x.ReactorReadercurrently returns the reactor project's build POM for every artifact whose extension ispom, without considering its classifier. Consequently, resolving an attached classified POM from the reactor returnspom.xmlinstead of the attached artifact.This change limits the build-POM shortcut to unclassified POM requests. Classified POMs proceed through the existing artifact matching path, which selects the attached artifact by extension and classifier. Ordinary reactor POM and consumer-POM resolution remain unchanged.
The production change is patch-identical to #12658. The Core IT uses the File/String-based verifier API and suite-order registration required by the
maven-4.0.xtest harness.Fixes apache/maven-dependency-plugin#1024
Tests
clean verify: all 38 modules passed with Maven 3.9.16 and Java 17.spotless:apply: no formatting changes.MavenITmdep0590ClassifiedPomArtifactFromReactorTestagainst the freshly built Maven4.0.0-SNAPSHOTdistribution: 1 test, 0 failures, 0 errors, 0 skipped.