[MNG-4921] Add qualityManagement element to POM model 4.2.0 #12842
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.maven.it; | ||
|
|
||
| import java.nio.file.Path; | ||
| import java.util.Properties; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| /** | ||
| * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-4921">MNG-4921</a>. | ||
| * | ||
| * Verifies that the {@code <qualityManagement>} element (POM model 4.2.0) is read from the POM, | ||
| * inherited from the parent and can be overridden by a child. | ||
| */ | ||
| class MavenITmng4921QualityManagementTest extends AbstractMavenIntegrationTestCase { | ||
|
|
||
| MavenITmng4921QualityManagementTest() {} | ||
|
|
||
| /** | ||
| * Verify that the quality management information is read from the effective model, inherited from the parent POM | ||
| * unless overridden by the child. | ||
| * | ||
| * @throws Exception in case of failure | ||
| */ | ||
| @Test | ||
| public void testitQualityManagement() throws Exception { | ||
| Path testDir = extractResources("mng-4921"); | ||
|
|
||
| Verifier verifier = newVerifier(testDir); | ||
| verifier.setAutoclean(false); | ||
| verifier.deleteDirectory("target"); | ||
| verifier.deleteDirectory("inherit/target"); | ||
| verifier.deleteDirectory("override/target"); | ||
| verifier.addCliArgument("validate"); | ||
| verifier.execute(); | ||
| verifier.verifyErrorFreeLog(); | ||
|
|
||
| Properties props = verifier.loadProperties("target/pom.properties"); | ||
| assertEquals("SonarQube", props.getProperty("project.qualityManagement.system")); | ||
| assertEquals("https://sonar.parent.example.org", props.getProperty("project.qualityManagement.url")); | ||
|
|
||
| // child without own qualityManagement inherits it from the parent | ||
| props = verifier.loadProperties("inherit/target/pom.properties"); | ||
| assertEquals("SonarQube", props.getProperty("project.qualityManagement.system")); | ||
| assertEquals("https://sonar.parent.example.org", props.getProperty("project.qualityManagement.url")); | ||
|
|
||
| // child declaring its own qualityManagement overrides the parent's | ||
| props = verifier.loadProperties("override/target/pom.properties"); | ||
| assertEquals("Coverity", props.getProperty("project.qualityManagement.system")); | ||
| assertEquals("https://scan.child.example.org", props.getProperty("project.qualityManagement.url")); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
| <project xmlns="http://maven.apache.org/POM/4.2.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.2.0 http://maven.apache.org/xsd/maven-4.2.0.xsd"> | ||
| <modelVersion>4.2.0</modelVersion> | ||
| <parent> | ||
| <groupId>org.apache.maven.its.mng4921</groupId> | ||
| <artifactId>mng4921</artifactId> | ||
| </parent> | ||
|
|
||
| <artifactId>mng4921-inherit</artifactId> | ||
| <packaging>jar</packaging> | ||
|
|
||
| <name>Maven Integration Test :: MNG-4921 :: Inherit</name> | ||
| <description>Quality management inherited from parent.</description> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.its.plugins</groupId> | ||
| <artifactId>maven-it-plugin-expression</artifactId> | ||
| <version>2.1-SNAPSHOT</version> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>eval</goal> | ||
| </goals> | ||
| <phase>validate</phase> | ||
| <configuration> | ||
| <outputFile>target/pom.properties</outputFile> | ||
| <expressions> | ||
| <expression>project</expression> | ||
| </expressions> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
| <project xmlns="http://maven.apache.org/POM/4.2.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.2.0 http://maven.apache.org/xsd/maven-4.2.0.xsd"> | ||
| <modelVersion>4.2.0</modelVersion> | ||
| <parent> | ||
| <groupId>org.apache.maven.its.mng4921</groupId> | ||
| <artifactId>mng4921</artifactId> | ||
| </parent> | ||
|
|
||
| <artifactId>mng4921-override</artifactId> | ||
| <packaging>jar</packaging> | ||
|
|
||
| <name>Maven Integration Test :: MNG-4921 :: Override</name> | ||
| <description>Quality management overridden by child.</description> | ||
|
|
||
| <qualityManagement> | ||
| <system>Coverity</system> | ||
| <url>https://scan.child.example.org</url> | ||
| </qualityManagement> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.its.plugins</groupId> | ||
| <artifactId>maven-it-plugin-expression</artifactId> | ||
| <version>2.1-SNAPSHOT</version> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>eval</goal> | ||
| </goals> | ||
| <phase>validate</phase> | ||
| <configuration> | ||
| <outputFile>target/pom.properties</outputFile> | ||
| <expressions> | ||
| <expression>project</expression> | ||
| </expressions> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really should explain what project's quality management information is instead rewriting the name from a camel case variable into prose. As is, I do not know what's expected here.