[Backport 4.0.x] Fix #12685: Add tests for war/ear plugin upgrades, extract Quarkus tests - #12876
Conversation
…des, extract Quarkus tests * Fix #12685: Add maven-war-plugin and maven-ear-plugin to plugin upgrade list Both plugins use reflection on java.util.Properties internals (via XStream/plexus-archiver) in older versions, which is blocked by the JDK 17+ module system. Since Maven 4 requires JDK 17+, mvnup should upgrade these plugins to compatible versions (>= 3.4.0). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: trim test file to stay within 2000-line Checkstyle limit Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor: extract Quarkus plugin tests to separate file Move the Quarkus-specific tests from PluginUpgradeStrategyTest to a new PluginUpgradeQuarkusTest class to stay well within the 2000-line Checkstyle limit and leave room for future plugin additions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Clean, faithful backport of #12808 to maven-4.0.x. The diffs are byte-identical to the original (all added and removed lines match exactly, with only expected hunk-header line-number offsets differing). All 24 CI checks pass across Linux/macOS/Windows on JDK 17/21/25.
The PluginUpgradeQuarkusTest.java extraction correctly keeps the original test file under the 2,000-line Checkstyle FileLength limit. The predefined plugin upgrades config test was properly compacted from individual boolean variables to a loop, adding maven-war-plugin and maven-ear-plugin to the assertion list.
Minor style nit (carried over from original PR, not a backport issue): assertTrue(newProp == null, ...) is used in two places instead of the more idiomatic assertNull(newProp, ...).
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
|
@gnodet Please assign appropriate label to PR according to the type of change. |
1 participant
Summary
Backport of #12808 to
maven-4.0.x.maven-war-pluginandmaven-ear-pluginupgrade entriesPluginUpgradeQuarkusTest.javato stay within the 2,000-line Checkstyle FileLength limitAll 52 tests pass on
maven-4.0.x.🤖 Generated with Claude Code