Fix #12774: skip consumer POM re-attachment on repeated task segments - #12956
Merged
Conversation
…#12916) * Fix #12774: skip consumer POM re-attachment on repeated task segments Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Hoist alreadyAttached check before temp file creation Avoid unnecessary I/O on repeated invocations by checking whether the consumer POM is already attached before creating a temp file and registering it for deferred deletion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
commented
Aug 30, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
Clean forward-port of #12916 from maven-4.0.x to master. No adaptation issues.
Observations (informational):
- Source code change to
ConsumerPomArtifactTransformer.javais identical to the merged #12916 — hoistedalreadyAttachedcheck correctly placed before temp file creation - Test properly adapted to master conventions: JUnit assertions instead of AssertJ,
Map.of()instead ofCollections.emptyMap() - The
alreadyAttachedcheck correctly usesa.getType()fororg.apache.maven.artifact.Artifact(fromproject.getAttachedArtifacts()) — distinct from theconsumerPomPresentmethod that usesa.getExtension()fororg.eclipse.aether.artifact.Artifact - All findings from our 2 prior reviews of #12916 remain addressed
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward port of #12916 from
maven-4.0.xtomaster.alreadyAttachedcheck before temp file creation to avoid unnecessary I/O on repeated invocationsinjectTransformedArtifactstwice does not duplicate the consumer POM artifact🤖 Generated with Claude Code