NIFI-15927 improvements to connector property group card#11237
Open
scottyaslan wants to merge 2 commits into
Open
NIFI-15927 improvements to connector property group card#11237scottyaslan wants to merge 2 commits into
scottyaslan wants to merge 2 commits into
Conversation
Contributor
|
Reviewing... |
mcgilman
requested changes
May 12, 2026
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the PR @scottyaslan! Noted a few things below.
mcgilman
requested changes
May 13, 2026
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the updates @scottyaslan! Just noted one thing below.
Comment on lines
+20
to
+24
| <mat-card-header> | ||
| <mat-card-title data-qa="property-group-name"> | ||
| {{ propertyGroup().propertyGroupName }} | ||
| </mat-card-title> | ||
| </mat-card-header> |
Contributor
There was a problem hiding this comment.
It looks like the card title is the same typography as the header in the summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15927
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation