NIFI-15945 - Parameter not correctly added to parameter context when having multiple suffixed parameter contexts#11255
Open
pvillard31 wants to merge 2 commits into
Open
NIFI-15945 - Parameter not correctly added to parameter context when having multiple suffixed parameter contexts#11255pvillard31 wants to merge 2 commits into
pvillard31 wants to merge 2 commits into
Conversation
…having multiple suffixed parameter contexts
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for addressing this issue @pvillard31. The changes look good, just one minor recommendation on the test class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15945 - Parameter not correctly added to parameter context when having multiple suffixed parameter contexts
Consider the following scenario: in a registry you have a versioned flow F at version N that represents a versioned process group attached to a parameter context P.
In NiFi, you import that flow three times with the flag that you don't want to re-use the parameter context. You get:
Now consider a new version of the flow F, version n+1, where a new parameter Z is added to P.
When you upgrade F_2 or F_3 to the version n+1, the parameter Z is not added to their bounded parameter context.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation