NIFI-15947 Replaced deprecated method expireAfterWrite of com.google.common.cache.CacheBuilder.#11258
Merged
Merged
Conversation
pvillard31
requested changes
May 16, 2026
| return MessageDigest.isEqual(value1.getBytes(StandardCharsets.UTF_8), value2.getBytes(StandardCharsets.UTF_8)); | ||
| } | ||
|
|
||
| private Duration getDuration(long duration, TimeUnit unit) { |
Contributor
There was a problem hiding this comment.
Could getDuration be replaced with a single call to Duration.of(duration, unit.toChronoUnit()), which handles every TimeUnit value correctly and removes the need for a helper method?
Contributor
Author
There was a problem hiding this comment.
Great point! I did not realize that existed.
I assume with this, the rest of the comments are OBE as I no longer need the getDuration method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15947
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation