drivers/usbdev/cdcecm.c: fix cdcecm netdev can not enter running state #17433
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: USB
Size: XS
acassis
reviewed
Dec 5, 2025
Contributor
acassis
left a comment
acassis
left a comment
There was a problem hiding this comment.
@zhhyu7 please include more details in the commit log message what is the problem and calling the netdev_carrier_on() fixes the issue. This way someone reading your commit in the future will be a better understating about the issue
When the setinterface interface is called, it indicates that the underlying USB link has been successfully established. At this point, the status of the network card needs to be updated to RUNNING by calling the netdev_carrier_on interface. It is similar to the logic after a Wi-Fi network card is connected to a hotspot. Otherwise, an incorrect network card status may cause packets to fail to be successfully sent. Signed-off-by: zhanghongyu <[email protected]>
xiaoxiang781216
approved these changes
Dec 6, 2025
Contributor
Author
Done. |
Contributor
|
Can you provide any logs from your testing? And fill out the impact section (something like "bug fix for CDCECM in scenario where ....") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the setinterface interface is called, it indicates that the underlying USB link has been successfully established. At this point, the status of the network card needs to be updated to RUNNING by calling the netdev_carrier_on interface. It is similar to the logic after a Wi-Fi network card is connected to a hotspot. Otherwise, an incorrect network card status may cause packets to fail to be successfully sent.
Impact
N/A
Testing
sim:usbdev
Establish a cdcecm network card connection with HOST Linux and send/receive packets.