drivers/can/can.c: fix broken O_NONBLOCK #17441
Open
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
drivers/can/can.c: fix broken O_NONBLOCK
O_NONBLOCK open mode was broken since #17360
MIN() comapres signed value (int) with unsigned value (size_t) which causes an unexpected return value when ret is negative.
Impact
fix regression
Testing
simulator with CAN.
a simple test showing that the previous code was wrong: