Fixed: error in creating category image content. (OFBIZ-12011) - #1694
Open
rehan3586 wants to merge 1 commit into
Open
Fixed: error in creating category image content. (OFBIZ-12011)#1694rehan3586 wants to merge 1 commit into
rehan3586 wants to merge 1 commit into
Conversation
| createCategoryContent.contentId = creConRes.contentId | ||
|
|
||
| createCategoryContent.contentId = parameters.contentId | ||
| run service: 'createCategoryContent', with: createCategoryContent | ||
| Map createCategoryResult = run service: 'createCategoryContent', with: createCategoryContent |
Contributor
There was a problem hiding this comment.
We should add service response handling here for the createCategoryContent call because if the service fails, the contentId will be added to the createCategoryResult, which is an error result.
Also, the contentId is optional=false in the service definition of this service, as it has to be returned properly in case of success.
Please check if this is properly handled here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: error in creating category image content
(OFBIZ-12011)
Explanation: the root cause was essentially a combination of incorrect parameter/field handling and missing ID propagation between the services involved in the category image upload process.
The fix ensures that the uploaded image is correctly received, its data resource is maintained, the generated content remains identifiable, and any service failure is properly surfaced
Thanks:
Aakash Jain for reporting the issue.