OPENNLP-1916: minor normalizer fix - #1235
Open
krickert wants to merge 1 commit into
Open
Conversation
Replaces the rung metaphor with "normalizer" wording in the javadoc, tests, and manual. AggregateCharSequenceNormalizer stored the caller varargs array as-is: a null array or element caused an NPE mid-normalize, and mutating the array afterwards changed the aggregate. Now throws IllegalArgumentException on null, keeps a defensive copy, and the loop no longer shadows the field. AggregateCharSequenceNormalizerTest covers order, both null rejections, and array-mutation isolation.
krickert
force-pushed
the
OPENNLP-1916-minor-normalizer-fix
branch
from
August 19, 2026 10:53
ef51733 to
c03c118
Compare
krickert
marked this pull request as ready for review
August 19, 2026 10:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate and copy the aggregate normalizer chain at construction: AggregateCharSequenceNormalizer stored the caller's varargs array as-is (null array or null element caused NPE mid-normalize, which cascaded into a changed aggregate).
I changed it to fail loudly.
Now throws IllegalArgumentException on null, defensive copy, shadow gone, constructor javadoc added, plus a new 4-test AggregateCharSequenceNormalizerTest covering order, both null rejections, and array-mutation isolation.
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.