Skip to content

OPENNLP-1916: minor normalizer fix - #1235

Open
krickert wants to merge 1 commit into
mainfrom
OPENNLP-1916-minor-normalizer-fix
Open

OPENNLP-1916: minor normalizer fix#1235
krickert wants to merge 1 commit into
mainfrom
OPENNLP-1916-minor-normalizer-fix

Conversation

@krickert

@krickert krickert commented Aug 19, 2026

Copy link
Copy Markdown
Contributor
  1. Minor: Replace the rung metaphor with "normalizer" wording.
  2. Minor:
    Validate and copy the aggregate normalizer chain at construction: AggregateCharSequenceNormalizer stored the caller's varargs array as-is (null array or null element caused NPE mid-normalize, which cascaded into a changed aggregate).

I changed it to fail loudly.

Now throws IllegalArgumentException on null, defensive copy, shadow gone, constructor javadoc added, plus a new 4-test AggregateCharSequenceNormalizerTest covering order, both null rejections, and array-mutation isolation.

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@krickert krickert changed the title Opennlp 1916 minor normalizer fix OPENNLP-1916: minor normalizer fix Aug 19, 2026
Replaces the rung metaphor with "normalizer" wording in the javadoc,
tests, and manual. AggregateCharSequenceNormalizer stored the caller
varargs array as-is: a null array or element caused an NPE
mid-normalize, and mutating the array afterwards changed the
aggregate. Now throws IllegalArgumentException on null, keeps a
defensive copy, and the loop no longer shadows the field.
AggregateCharSequenceNormalizerTest covers order, both null
rejections, and array-mutation isolation.
@krickert
krickert force-pushed the OPENNLP-1916-minor-normalizer-fix branch from ef51733 to c03c118 Compare August 19, 2026 10:53
@krickert
krickert marked this pull request as ready for review August 19, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant