fix: add flex-shrink style for labels#547
Merged
Merged
Conversation
wu-sheng
previously approved these changes
Apr 18, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses label layout issues in dashboard filter/header components by preventing label text from shrinking in flex layouts and aligning label line-height with Element Plus input height.
Changes:
- Update
.labelstyling to useline-height: var(--el-input-height, 24px)and addflex-shrink: 0. - Apply the
.labelclass to the TraceListtraceIDlabel for consistent styling. - Remove
margin-bottomfrom the Marketplace.linkstyle.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/views/dashboard/related/trace/components/TraceList/Filter.vue | Adds .label class to traceID label and updates .label CSS to avoid shrinking in flex contexts. |
| src/views/dashboard/related/log/Header.vue | Updates .label CSS to prevent shrinking and align line-height with input height. |
| src/views/dashboard/related/event/Header.vue | Updates .label CSS to prevent shrinking and align line-height with input height. |
| src/views/Marketplace.vue | Removes .link margin-bottom (unrelated to label flex-shrink change). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wu-sheng
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshot
Signed-off-by: Qiuxia Fan qiuxiafan@apache.org