feat: support trace v1 in trace single page#549
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for viewing Trace v1 (basic trace + span query) in the trace single-page route by conditionally rendering the legacy span detail UI when Trace v2 APIs aren’t available.
Changes:
- Update trace single page to render
TraceContentfor v2 andSpanListfor v1 based on backend capability. - Add
getTraceByTraceId()action to the trace store to drive the single-page trace fetch flow. - Pass
minTimestamp/maxTimestampinto the trace graph components to constrain the time window.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/views/dashboard/related/trace/components/TraceList/SpanList.vue | Adds min/max timestamp bounds passed into the trace visualization component. |
| src/views/dashboard/Trace.vue | Switches single-page rendering logic between v2 (TraceContent) and v1 (SpanList) flows. |
| src/store/modules/trace.ts | Introduces getTraceByTraceId() and refactors v1/v2 selection logic in getTraces(). |
| src/layout/components/NavBar.vue | Removes eager capability query call from navbar initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wu-sheng
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes apache/skywalking#13842
screenshot
Signed-off-by: Qiuxia Fan qiuxiafan@apache.org