Conversation
|
Please fix CI. |
mrproliu
left a comment
mrproliu
left a comment
There was a problem hiding this comment.
Please fix all the comment and add a new plugin test for it.
go.mod
Outdated
| require ( | ||
| github.com/google/uuid v1.3.0 | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/segmentio/kafka-go v0.4.48 |
There was a problem hiding this comment.
Why there have dependency changes?
There was a problem hiding this comment.
When I run go mod tidy, Kafka is automatically added to go.mod. Using go mod why, I found that it is being used in the reporter.
go mod why -m github.com/segmentio/kafka-go
# github.com/segmentio/kafka-go
github.com/apache/skywalking-go/agent/reporter
github.com/segmentio/kafka-goThere was a problem hiding this comment.
go mod tidy is use for the single module, in the go work concept, you should use go work sync.
|
Why does this commit hash appear to be wrong? My last commit ID is 3012842, but the CI build is using 4b51072. I expected the CI to build the latest commit, so I’m trying to understand why it’s picking an error one. @mrproliu thanks.
|
|
It will merge the main branch into your branch, so it's fine to run this. You should focus on the CI issue, rather than the commit ID. |
3 participants
Support Gozero framework