build: fetch BATS test libs via HTTP instead of npm/node#4587
Open
dsmiley wants to merge 1 commit into
Open
Conversation
The packaging module pulled in the node-gradle plugin solely to run `npm install <github-url>#<tag>` for bats-core/bats-assert/bats-file (npm was just being used as a git-URL fetcher here, nothing JS-related). Replace downloadBats with a plain Gradle task that fetches GitHub tag archives over HTTP and extracts them with tarTree, removing node/npm from :solr:packaging entirely and simplifying the proxy story to standard Gradle systemProp.http(s).proxyHost/Port config. Also pin bats-support (previously an undeclared transitive dependency pulled in via bats-assert's package.json) explicitly in the version catalog. Remove undercounch.download plugin (unused).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packaging module pulled in the node-gradle plugin solely to run
npm install <github-url>#<tag>for bats-core/bats-assert/bats-file (npm was just being used as a git-URL fetcher here, nothing JS-related). Replace downloadBats with a plain Gradle task that fetches GitHub tag archives over HTTP and extracts them with tarTree, removing node/npm from :solr:packaging entirely and simplifying the proxy story to standard Gradle systemProp.http(s).proxyHost/Port config.Also pin bats-support (previously an undeclared transitive dependency pulled in via bats-assert's package.json) explicitly in the version catalog. Remove undercounch.download plugin (unused).