verify-release-file.sh: check .sha512 files with sha512sum -c#8906
Merged
GGraziadei merged 1 commit intoJul 19, 2026
Merged
Conversation
The script compared the output of 'gpg --print-md SHA512' textually against the published .sha512 file, but release .sha512 files are generated in sha512sum format, so the diff always failed and the script reported 'SHA file is not correct' even when the hash matched. Verified against the apache-storm-2.8.9-rc1 artifacts: the script now reports 'SHA file is correct' for a valid file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rzo1
approved these changes
Jul 19, 2026
reiabreu
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
dev-tools/rc/verify-release-file.shalways reportsSHA file is not correctfor release candidates, even when the checksum is valid. The script compares the output ofgpg --print-md SHA512(uppercase hash, split in 8-char blocks across multiple lines) textually with the published.sha512file, but release.sha512files are generated insha512sumformat (lowercase continuous hash followed by the file name), so thediffnever matches.This replaces the
gpg --print-md+diffcomparison withsha512sum -c, which verifies the checksum regardless of formatting.How was the change tested
Ran the script against the
apache-storm-2.8.9-rc1artifacts fromdist.apache.org:Signature seems correct/SHA file is not correct(false negative on every file)Signature seems correct/apache-storm-2.8.9-src.tar.gz: OK — SHA file is correct🤖 Generated with Claude Code